Normalize wheel RECORD paths (on Windows)#2965
Merged
Conversation
Member
|
Thanks for the PR, Windows CI is failing, we need to get it fixed to merge this. |
0c1e111 to
a6392a1
Compare
messense
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2870 refactored
module_writer.rs, and in doing so removed a line which reformattedPathBufrendered platform-specificStrings to exclusively us/:While it seems this is technically allowed, some tools choke on this. In my case, the
wheelpackage does not like windows-style paths in theRECORDfile (even on Windows itself).I've also added a unit test to validate this - though because the implementation uses
PathBuf::to_string_lossy, it will only actually fail on Windows.